jonahgao commented on PR #21827: URL: https://github.com/apache/datafusion/pull/21827#issuecomment-4323877292
> However, the assertion in `with_new_children` is still fragile — any `transform_up` based optimizer that changes a child's output partitioning will trigger a panic. `assert_or_internal_err` only returns an `internal_err`, and it seems like the optimizer didn’t propagate the error correctly, causing a panic. I think it is appropriate to return an error here. It should be up to the user (e.g., the optimizer rule) to decide whether to fall back or to preserve the partitioning properties of InterleaveExec’s children. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
