andygrove opened a new pull request, #1584: URL: https://github.com/apache/datafusion-ballista/pull/1584
## Summary Removes the `else` branch in `CustomObjectStoreRegistry::s3_object_store_builder` that returned a hard error when `s3.access_key_id` and `s3.secret_access_key` were not explicitly set via SQL `SET` commands. `AmazonS3Builder::from_env()` already supports the full AWS credential chain — environment variables, IRSA web identity tokens, instance profiles, etc. The explicit credential check was redundant and prevented these standard mechanisms from working. Fixes #1583 ## Test plan - [ ] Deploy scheduler + executor with `AWS_REGION` set and credentials provided via instance profile or IRSA (no explicit `SET s3.*` commands) - [ ] Verify S3 tables can be registered and queried successfully - [ ] Verify explicit credentials via `SET s3.access_key_id` / `SET s3.secret_access_key` still work 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
