sandugood commented on code in PR #1547:
URL:
https://github.com/apache/datafusion-ballista/pull/1547#discussion_r3143845006
##########
ballista/executor/src/executor_process.rs:
##########
@@ -229,8 +235,30 @@ pub async fn start_executor_process(
);
info!("Executor id: {executor_id}");
info!("Executor working directory: {work_dir}");
- info!("Executor number of concurrent tasks: {concurrent_tasks}");
+ info!(
+ "Executor number of concurrent tasks (available CPU cores):
{concurrent_tasks}"
+ );
info!("Executor scheduling policy: {task_scheduling_policy:?}");
+ // Getting system-wide specs for executor registration
+ let system_name =
+ System::name().unwrap_or_else(|| String::from("Unknown system name"));
+ let os_ver =
+ System::os_version().unwrap_or_else(|| String::from("Unknown OS
version"));
+ let os_ver_long = System::long_os_version()
+ .unwrap_or_else(|| String::from("Unknown long OS version"));
+ let kernel_ver = System::kernel_long_version();
+
+ let physical_cores = System::physical_core_count().unwrap_or(0) as u32;
+ let open_files_limit = System::open_files_limit().unwrap_or(0) as u64;
+
+ let disks = Disks::new_with_refreshed_list();
+ let num_disks = disks.list().len() as u32;
+ let mut total_disk_space: u64 = 0;
+ let mut total_available_disk_space: u64 = 0;
+ for disk in &disks {
+ total_disk_space += disk.total_space();
+ total_available_disk_space += disk.available_space();
+ }
Review Comment:
Great suggestion, thanks
moved to **structure_executor_metadata** function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
