Weijun-H commented on code in PR #21840:
URL: https://github.com/apache/datafusion/pull/21840#discussion_r3142939820
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -85,7 +85,8 @@ impl fmt::Display for DigestAlgorithm {
}
macro_rules! digest_to_array {
- ($METHOD:ident, $INPUT:expr) => {{
+ ($MODULE:ident, $METHOD:ident, $INPUT:expr) => {{
+ use $MODULE::Digest;
Review Comment:
nit:
This is a reasonable way to handle the mixed `digest` versions. Another
readability option would be to use UFCS, e.g. `<$METHOD as
$MODULE::Digest>::digest(...)`, so the trait version is explicit at the call
site. Not necessary for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
