stuhood commented on code in PR #21807:
URL: https://github.com/apache/datafusion/pull/21807#discussion_r3140886885
##########
datafusion/physical-expr/Cargo.toml:
##########
@@ -55,6 +55,7 @@ indexmap = { workspace = true }
itertools = { workspace = true, features = ["use_std"] }
parking_lot = { workspace = true }
petgraph = "0.8.3"
+rand = { workspace = true }
Review Comment:
I'm less worried about collisions, and more worried about non-determinism
(causing flaky tests, different plans to be generated randomly, etc). The other
annoying aspect of random ids is that they are huge. If you go ahead and
actually render this everywhere, a random ID is going to take up a lot more
space than one generated on a context (...starting from 0, etc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
