timsaucer opened a new issue, #1507: URL: https://github.com/apache/datafusion-python/issues/1507
The following comment on PR #1484. See the issue for further context. One small nit. It probably makes sense to just land this then resolve the nit (if desired). Follow on opportunities mostly reviewing functions (just grepped for `lit`), raw Any isn't great so we could potentially find a slightly narrower type: * in_list `values: list[Expr | Any?]` * Remove the lit in the count_star example (unrelated to changes here but in the spirit of showing we don't need lit nearly anywhere there are actually a bunch of filters that use lit that I don't think they need * Probably can use this approach to build out further lit coverage (CaseBuilder example as a part of functions) * round doc string has a `for example` that can probably just be pruned for the doc string example * make_array `*args: Expr | Any` * range `Expr | float?` * named_struct `list[tuple[str, Expr | Any]]` * array_append * array_has * array_position, index covered but element could be extended * array_positions * array_prepend * array_remove * array_remove_n * array_remove_all * array_repeat * array_replace * array_replace_n * array_replace_all * array_resize * gen_series * map_extract _Originally posted by @ntjohnson1 in https://github.com/apache/datafusion-python/pull/1484#pullrequestreview-4135923349_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
