andygrove opened a new pull request, #4065:
URL: https://github.com/apache/datafusion-comet/pull/4065
## Which issue does this PR close?
Closes #.
## Rationale for this change
The `array_insert` expression was previously marked `Incompatible`,
requiring `spark.comet.expr.allowIncompatible=true` to use. A recent audit
against Spark 3.4.3, 3.5.8, and 4.0.1 found no behavioral differences beyond a
cosmetic error-message mismatch when `pos=0` (Comet throws a generic error
while Spark raises `INVALID_INDEX_OF_ZERO`). That falls within the `Compatible`
contract ("may have known differences in some specific edge cases that are
unlikely to be an issue for most users"), so users no longer need to opt in to
incompatible expressions for this function.
The expression audit log has also accumulated a single entry and lives in
its own file. Folding that metadata into the main expression support doc keeps
audit findings next to the coverage matrix, and moving that doc into the
contributor guide makes it discoverable through the Sphinx toctree.
## What changes are included in this PR?
- Change `CometArrayInsert.getSupportLevel` from `Incompatible(None)` to
`Compatible()`.
- Move `docs/spark_expressions_support.md` into
`docs/source/contributor-guide/` and add it to the contributor-guide toctree.
- Merge the `expression-audit-log.md` contents into the support doc as
per-version sub-bullets under `array_insert`, then delete the audit log.
- Update the `audit-comet-expression` skill and `adding_a_new_expression.md`
link to point at the new location.
## How are these changes tested?
Covered by existing `array_insert` tests added during the audit. No new
behavior is introduced; this PR only relaxes the support-level gate and
reorganizes docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
