sgrebnov commented on code in PR #21694:
URL: https://github.com/apache/datafusion/pull/21694#discussion_r3136302886


##########
datafusion/sql/src/unparser/plan.rs:
##########
@@ -683,28 +683,37 @@ impl Unparser<'_> {
 
                 let join_filters = if table_scan_filters.is_empty() {
                     join.filter.clone()
+                } else if join.join_type == JoinType::Inner {

Review Comment:
   Great point, thank you - added `split_join_on_and_where_filters` helper fn. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to