wirybeaver commented on PR #20763: URL: https://github.com/apache/datafusion/pull/20763#issuecomment-4311156414
Thanks for the review @ethan-tyler. Addressed the three inline comments in the amended commit and added tests for the new public types: `write_op_merge_into_name_and_display` in `datafusion-expr` and `roundtrip_logical_plan_dml_merge_into` in `datafusion-proto` (full `LogicalPlan::Dml → bytes → LogicalPlan::Dml` round-trip exercising the new proto wiring), plus two narrower tests for the `MergeInto` proto tag and the missing-payload error path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
