akshaychitneni commented on PR #1568: URL: https://github.com/apache/datafusion-ballista/pull/1568#issuecomment-4308669664
> > Thanks for pointing out. I think the listener approach might be helpful when running in Kubernetes-like environments, as callbacks run inline in the scheduler's event loop, avoiding silent event loss scenarios that can occur with a separate consumer thread. > > Having listeners on scheduler loop may keep it busy from handling scheduler related tasks, like heart bits. > > If listeners are slow to process they may impacts the scheduler. In case of separate consumer thread it's up to consumer to keep up with the stream > > I'm using this approach already and no problems so far > > I'd suggest we start with current implementation and change if we find it problematic > > Wdyt? Makes sense. thanks for sharing. I will try out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
