theirix opened a new pull request, #21810: URL: https://github.com/apache/datafusion/pull/21810
## Which issue does this PR close? - Follow-up to #21544 ## Rationale for this change @Jefffrey [noted](https://github.com/apache/datafusion/pull/21544#discussion_r3129631052) that some bench helpers created a special distribution of values, so we can revisit their usage. ## What changes are included in this PR? Some of the helpers are created for the purpose. For this reason, I initially avoided migrating most candidate helpers from other files (`array_has`, `array_sort` etc). - `array_remove`'s helpers (`create_f64_list_array` and `create_decimal64_list_array`) should be brought back because the probability of finding a needle depends on the distribution, which is set explicitly instead of the range of a template parameter - bringing them back in this PR - array_min_max is safe since it locates a min/max elements, which isn't affected by the value distribution - array_repeat doesn't check contents, so it is safe - array_to_string is not content-aware ## Are these changes tested? Run changed benchmarks ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
