adriangb commented on PR #21623: URL: https://github.com/apache/datafusion/pull/21623#issuecomment-4306803448
Thanks for the PR! Personally I would like to review: 1. A PR that adds the method to `PhysicalExpr` and all of the implementations, with unit tests for each one (especially the complex ones like `CaseExpr` or `BinaryExpr`) 2. A followup PR that uses these methods for `EliminateOuterJoin` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
