nathanb9 commented on code in PR #21803:
URL: https://github.com/apache/datafusion/pull/21803#discussion_r3132062682
##########
datafusion/execution/src/memory_pool/mod.rs:
##########
@@ -182,7 +183,7 @@ pub use pool::*;
///
/// * [`TrackConsumersPool`]: Wraps another [`MemoryPool`] and tracks
consumers,
/// providing better error messages on the largest memory users.
-pub trait MemoryPool: Send + Sync + std::fmt::Debug + Display {
+pub trait MemoryPool: Any + Send + Sync + std::fmt::Debug + Display {
Review Comment:
Adding Any as a supertrait adds a `'static` requirement to every MemoryPool
implementor. This might break downstream if they have implemented custom pools
which borrowed state or lifetime parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
