Omega359 commented on code in PR #21707:
URL: https://github.com/apache/datafusion/pull/21707#discussion_r3131411863
##########
benchmarks/sql_benchmarks/tpch/tpch.benchmark.template:
##########
@@ -0,0 +1,18 @@
+name Q${QUERY_NUMBER_PADDED}
+group tpch
+subgroup sf${BENCH_SIZE:-1}
+
+init sql_benchmarks/tpch/init/set_config.sql
+
+echo Loading tpch sf${BENCH_SIZE:-1} ${TPCH_FILE_TYPE:-parquet} data
+
+load sql_benchmarks/tpch/init/load_${TPCH_FILE_TYPE:-parquet}.sql
+
+assert I
Review Comment:
Interesting idea. Followup PR possibly. The assertion code here doesn't
handle types at all - only strings whereas the sqllogictests are obviously a
bit more advanced. It's mostly meant to validate that a table was loaded since
`create external table ...` doesn't fail if the file being loaded doesn't
exist. That was kinda a WTF moment for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
