mbutrovich commented on PR #3146: URL: https://github.com/apache/datafusion-comet/pull/3146#issuecomment-4304540342
This was the only nit: > Byte/Short/Decimal still unsupported — Comet will fall back to Spark for these, which is fine, but getSupportLevel doesn't check child types. If someone does > timestamp_seconds(CAST(x AS TINYINT)), it would hit a DataFusion planning error rather than a clean Comet fallback. An override like the one in > CometArrayPosition.getSupportLevel that checks input types would be more robust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
