Dandandan commented on code in PR #20500:
URL: https://github.com/apache/datafusion/pull/20500#discussion_r3130789326
##########
datafusion/physical-plan/src/common.rs:
##########
@@ -204,6 +205,31 @@ pub fn can_project(
}
}
+/// Return a new `RecordBatch` with [`StringViewArray::gc`] called on such
columns (if any).
+pub(crate) fn gc_stringview_arrays(
+ batch: RecordBatch,
+) -> Result<RecordBatch, ArrowError> {
+ let mut new_columns: Vec<Arc<dyn Array>> =
Vec::with_capacity(batch.num_columns());
+
+ let mut arr_mutated = false;
+ for array in batch.columns() {
+ if let Some(string_view_array) =
array.as_any().downcast_ref::<StringViewArray>()
+ {
+ let new_array = string_view_array.gc();
Review Comment:
Yeah, I tried it again, but I did still see a small regression compared to
the morsel PR coalesce upstream.
Perhaps it can still extract some more parallelism in certain cases (e.g. it
can still do coalescing in another task/thread and start triggering IO request
again?).
I couldn't solve it yet but feel free to try again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
