Jefffrey commented on code in PR #20813:
URL: https://github.com/apache/datafusion/pull/20813#discussion_r3130071684
##########
datafusion/common/src/config.rs:
##########
@@ -2927,6 +2938,13 @@ config_namespace! {
pub terminator: Option<u8>, default = None
pub escape: Option<u8>, default = None
pub double_quote: Option<bool>, default = None
+ /// Quote style for CSV writing.
+ /// One of: "Always", "Necessary", "NonNumeric", "Never"
+ pub quote_style: CsvQuoteStyle, default = CsvQuoteStyle::Necessary
+ /// Whether to ignore leading whitespace in string values when writing
CSV.
+ pub ignore_leading_whitespace: Option<bool>, default = None
+ /// Whether to ignore trailing whitespace in string values when
writing CSV.
+ pub ignore_trailing_whitespace: Option<bool>, default = None
/// Specifies whether newlines in (quoted) values are supported.
Review Comment:
Should be fine to leave them as `Option<bool>`; but would be good to have a
docstring explaining what the default is in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
