gabotechs commented on code in PR #21764:
URL: https://github.com/apache/datafusion/pull/21764#discussion_r3129545937
##########
datafusion/functions/src/core/nullif.rs:
##########
@@ -251,6 +260,88 @@ mod tests {
Ok(())
}
+ #[test]
+ fn nullif_struct() -> Result<()> {
Review Comment:
Can we add a new test comparing a nested array VS a non-nested array? I
imagine the result of comparing both should return false, but I'm not sure if
right now that would happen, as we might hit this line here:
https://github.com/apache/datafusion/blob/branch-53/datafusion/physical-expr-common/src/datum.rs#L145-L145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
