parthchandra opened a new pull request, #4039: URL: https://github.com/apache/datafusion-comet/pull/4039
## Summary
Add TimestampNTZ support for temporal expressions and fix DST offset
calculation in `date_trunc`.
**Key changes:**
- Add TimestampNTZ support to `unix_timestamp` (no timezone conversion —
simply divides microseconds by 1,000,000)
- Fix DST offset calculation in `as_micros_from_unix_epoch_utc` so
`date_trunc` produces correct results when truncation crosses DST boundaries
(e.g., December/PST to October/PDT)
- Add TimestampNTZ tests for `hour`/`minute`/`second`, `date_trunc`, and
`date_format`
- Document chrono-tz limitation: DST calculations may be inaccurate for
dates beyond ~2100
**Not included in this PR:** TimestampNTZ cast support (to/from String,
Date, Timestamp, Long) — that will come in a separate PR.
## Test plan
- [ ] Run temporal expression tests: `mvn test -pl spark -Pspark-4.0
-Dsuites="org.apache.comet.CometTemporalExpressionSuite"`
- [ ] Rust compilation: `cargo check -p datafusion-comet-spark-expr`
- [ ] Full test suite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
