mkleen commented on code in PR #20047:
URL: https://github.com/apache/datafusion/pull/20047#discussion_r3123770486
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1752,7 +1766,9 @@ impl SessionContext {
let config = ListingTableConfig::new(table_path)
.with_listing_options(options)
.with_schema(resolved_schema);
- let table =
ListingTable::try_new(config)?.with_definition(sql_definition);
+ let table = ListingTable::try_new(config)?
+ .with_definition(sql_definition)
+
.with_cache(self.runtime_env().cache_manager.get_file_statistic_cache());
Review Comment:
@kosiew I now added the cache on the listing table in `_read_type()` and on
all locations where a listing table is created with `with_collect_stat(true)`
where therefore caching makes sense. Could you please do another review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
