Omega359 commented on code in PR #21707:
URL: https://github.com/apache/datafusion/pull/21707#discussion_r3119313285
##########
benchmarks/bench.sh:
##########
@@ -685,14 +686,16 @@ run_tpch() {
echo "Internal error: Scale factor not specified"
exit 1
fi
- TPCH_DIR="${DATA_DIR}/tpch_sf${SCALE_FACTOR}"
-
- RESULTS_FILE="${RESULTS_DIR}/tpch_sf${SCALE_FACTOR}.json"
- echo "RESULTS_FILE: ${RESULTS_FILE}"
+ FORMAT=$2
echo "Running tpch benchmark..."
- FORMAT=$2
- debug_run $CARGO_COMMAND --bin dfbench -- tpch --iterations 5 --path
"${TPCH_DIR}" --scale-factor "${SCALE_FACTOR}" --prefer_hash_join
"${PREFER_HASH_JOIN}" --format ${FORMAT} -o "${RESULTS_FILE}" ${QUERY_ARG}
${LATENCY_ARG}
+ debug_run env BENCH_NAME=tpch \
+ BENCH_SIZE="${SCALE_FACTOR}" \
+ PREFER_HASH_JOIN="${PREFER_HASH_JOIN}" \
+ TPCH_FILE_TYPE="${FORMAT}" \
+ SIMULATE_LATENCY="${SIMULATE_LATENCY}" \
+ ${QUERY_ARG} \
Review Comment:
I was looking for something like that but I didn't find ':+' .. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
