erenavsarogullari commented on code in PR #20387:
URL: https://github.com/apache/datafusion/pull/20387#discussion_r3115237116
##########
datafusion/execution/src/memory_pool/pool.rs:
##########
@@ -362,6 +421,21 @@ pub struct TrackConsumersPool<I> {
tracked_consumers: Mutex<HashMap<usize, TrackedConsumer>>,
}
+impl<I: MemoryPool> Display for TrackConsumersPool<I> {
+ fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+ write!(
+ f,
+ "{}",
+ format_args!(
Review Comment:
Fixed by the last commit. Thanks for the review.
##########
datafusion/execution/src/memory_pool/pool.rs:
##########
@@ -249,6 +292,20 @@ impl MemoryPool for FairSpillPool {
}
}
+impl Display for FairSpillPool {
Review Comment:
Currently, both `GreedyMemoryPool` and `UnboundedMemoryPool` track used
memory size. `FairSpillPool` can also be extended to track it. I think it can
be useful extension. Does it make sense to address it by a follow-up issue? If
so, i can create an issue and work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
