nathanb9 commented on PR #21425: URL: https://github.com/apache/datafusion/pull/21425#issuecomment-4282482253
Thanks for looking. > From what I understand velox will stop execution of operator before letting reclaimer access operator state, how would this proposal handle such case? @milenkovicm Yep, thats my understanding of velox as well. Initially, my thought was to deal with it at the operator level so basically like velox too. So something like this sample from velox: ```C++ nonReclaimableSection_ = false; pool->reserve(bytes); // safe nonReclaimableSection_ = false; ``` But seems like antipattern with a requires bunch of locks.... unreasonable to push this concurrency problem constraint onto each worker. So re-considering this and leaning towards exploring reclaim stream youre suggesting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
