LiaCastaneda commented on code in PR #21589: URL: https://github.com/apache/datafusion/pull/21589#discussion_r3109591081
########## datafusion/physical-plan/src/aggregates/group_values/single_group_by/mod.rs: ########## @@ -20,4 +20,5 @@ pub(crate) mod boolean; pub(crate) mod bytes; pub(crate) mod bytes_view; +pub mod dictionary; Review Comment: Looks like you removed the benchmarks -- should we make it private again? If you need it in the future maybe a bench specific function instead is better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
