Jefffrey commented on code in PR #21704:
URL: https://github.com/apache/datafusion/pull/21704#discussion_r3104866803
##########
datafusion/functions-nested/src/concat.rs:
##########
@@ -317,10 +317,23 @@ impl ScalarUDFImpl for ArrayConcat {
}
fn coerce_types(&self, arg_types: &[DataType]) -> Result<Vec<DataType>> {
- let base_type = base_type(&self.return_type(arg_types)?);
Review Comment:
I just realized something funny the existing implementation does; it calls
`return_type` within `coerce_types` even though the docstring for `return_type`
states that the input types are already coerced (i.e. `coerce_types` would have
already been called) 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
