hsiang-c commented on code in PR #3643:
URL: https://github.com/apache/datafusion-comet/pull/3643#discussion_r3102666065
##########
native/core/src/execution/planner.rs:
##########
@@ -682,6 +682,20 @@ impl PhysicalPlanner {
csv_write_options,
)))
}
+ ExprStruct::ArraysZip(expr) => {
+ assert!(!expr.values.is_empty());
Review Comment:
Makes sense. I fixed the first one.
The 2nd check on length makes sense. Spark's ArraysZip has done the check at
https://github.com/apache/spark/blob/branch-4.1/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala#L313-L315.
I think we should be safe here b/c of Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
