berkaysynnada commented on code in PR #20744:
URL: https://github.com/apache/datafusion/pull/20744#discussion_r3097367263
##########
datafusion/sql/src/statement.rs:
##########
@@ -2340,7 +2341,14 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
}
}
}
- let prepare_param_data_types =
prepare_param_data_types.into_values().collect();
+ let prepare_param_data_types: Vec<Option<FieldRef>> =
Review Comment:
this can be rewritten more idiomatic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]