wForget opened a new pull request, #3959: URL: https://github.com/apache/datafusion-comet/pull/3959
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #. ## Rationale for this change `CometExecIterator.close` is not always registered to the task completion listener, which may lead to leaks when task fails. Like: https://github.com/apache/datafusion-comet/blob/29557ca898764057d8f314cb2334154030ba161e/spark/src/main/scala/org/apache/spark/sql/comet/CometNativeWriteExec.scala#L207 https://github.com/apache/datafusion-comet/blob/29557ca898764057d8f314cb2334154030ba161e/spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometNativeShuffleWriter.scala#L99 ## What changes are included in this PR? Always register a task completion listener for `CometExecIterator.close`. ## How are these changes tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
