coderfender commented on code in PR #3948:
URL: https://github.com/apache/datafusion-comet/pull/3948#discussion_r3084676280
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -637,6 +637,18 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
DataTypes.LongType)
}
+ test("cast DecimalType(38,18) to FloatType") {
+ castTest(generateDecimalsPrecision38Scale18(), DataTypes.FloatType)
+ }
+
+ test("cast DecimalType(38,18) to DoubleType") {
+ castTest(generateDecimalsPrecision38Scale18(), DataTypes.DoubleType)
+ }
+
+ test("cast DecimalType(38,18) to BooleanType") {
+ castTest(generateDecimalsPrecision38Scale18(), DataTypes.BooleanType)
+ }
Review Comment:
We might also want to add some edge cases here to gain more confidence
##########
spark/src/test/resources/sql-tests/expressions/cast/cast_decimal_to_primitive.sql:
##########
@@ -0,0 +1,96 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+
+-- ConfigMatrix: parquet.enable.dictionary=false,true
+
+statement
+CREATE TABLE test_cast_decimal(d10 decimal(10,2), d5 decimal(5,0)) USING
parquet
+
+statement
+INSERT INTO test_cast_decimal VALUES
+ (123.45, 123),
+ (-67.89, -67),
+ (0.00, 0),
+ (0.01, 1),
+ (-0.01, -1),
+ (99999999.99, 99999),
+ (-99999999.99, -99999),
+ (NULL, NULL)
+
+-- decimal(10,2) column to FLOAT
+query
+SELECT cast(d10 as float) FROM test_cast_decimal
+
+-- decimal(10,2) column to DOUBLE
+query
+SELECT cast(d10 as double) FROM test_cast_decimal
+
+-- decimal(10,2) column to BOOLEAN
+query
+SELECT cast(d10 as boolean) FROM test_cast_decimal
+
+-- decimal(5,0) column to FLOAT
+query
+SELECT cast(d5 as float) FROM test_cast_decimal
+
+-- decimal(5,0) column to DOUBLE
+query
+SELECT cast(d5 as double) FROM test_cast_decimal
+
+-- decimal(5,0) column to BOOLEAN
+query
+SELECT cast(d5 as boolean) FROM test_cast_decimal
+
+-- decimal(38,18) table: covers boundary values that exercise the i128 code
path
+statement
+CREATE TABLE test_cast_decimal_high_precision(d38 decimal(38,18)) USING parquet
+
+statement
+INSERT INTO test_cast_decimal_high_precision VALUES
+ (CAST('99999999999999999999.999999999999999999' AS decimal(38,18))),
+ (CAST('-99999999999999999999.999999999999999999' AS decimal(38,18))),
+ (CAST('9223372036854775807.000000000000000000' AS decimal(38,18))),
+ (CAST('-9223372036854775808.000000000000000000' AS decimal(38,18))),
+ (CAST('1.000000000000000000' AS decimal(38,18))),
+ (CAST('-1.000000000000000000' AS decimal(38,18))),
+ (CAST('0.000000000000000000' AS decimal(38,18))),
+ (NULL)
+
+-- decimal(38,18) column to FLOAT
+query
+SELECT cast(d38 as float) FROM test_cast_decimal_high_precision
+
+-- decimal(38,18) column to DOUBLE
+query
+SELECT cast(d38 as double) FROM test_cast_decimal_high_precision
+
+-- decimal(38,18) column to BOOLEAN
+query
+SELECT cast(d38 as boolean) FROM test_cast_decimal_high_precision
+
+-- literal casts: decimal(10,2) to float
+query
+SELECT cast(cast(1.50 as decimal(10,2)) as float),
+ cast(cast(0.00 as decimal(10,2)) as float),
+ cast(cast(-1.50 as decimal(10,2)) as float),
+ cast(cast(NULL as decimal(10,2)) as float)
+
+-- literal casts: decimal(10,2) to boolean
+query
+SELECT cast(cast(1.50 as decimal(10,2)) as boolean),
+ cast(cast(0.00 as decimal(10,2)) as boolean),
+ cast(cast(NULL as decimal(10,2)) as boolean)
Review Comment:
Perhaps we could improve variability by adding more scale / precision
options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
