adriangb commented on PR #21351: URL: https://github.com/apache/datafusion/pull/21351#issuecomment-4245910263
> This PR has almost 500 lines of tests / test infrastructure. The actual code changes are pretty small > > I recommend reviewing this PR: > > 1. Start with the API changes to the `DataSource` trait > > 2. Look at the changes to ScanState to see how the shared state is used > > 3. Review the tests in file_stream/mod.rs > > 4. Most of the rest of the code changes are plumbing to get the shared state into ScanState Mind taking it out of draft if it is ready for review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
