ntjohnson1 commented on code in PR #1493:
URL:
https://github.com/apache/datafusion-python/pull/1493#discussion_r3075923477
##########
python/datafusion/expr.py:
##########
@@ -277,6 +277,25 @@ def _iter(
return list(_iter(exprs))
+def _to_raw_literal_expr(value: Expr | Any) -> expr_internal.Expr:
Review Comment:
I think this is fine to use internally but for the public api surface we
don't want to take Any. Would be nicer to be Expr | str for example on the
string functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
