andygrove commented on code in PR #3892:
URL: https://github.com/apache/datafusion-comet/pull/3892#discussion_r3073036229
##########
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##########
@@ -584,20 +584,18 @@ object CometStddevPop extends
CometAggregateExpressionSerde[StddevPop] with Come
}
object CometCorr extends CometAggregateExpressionSerde[Corr] {
-
- override def getSupportLevel(expr: Corr): SupportLevel =
Review Comment:
Same.
Worth double-checking: the original incompatibility note said "returns null
instead of NaN in some edge cases." That also describes the behavior in
correlation.rs:evaluate() when stddev is zero (constant values produce
stddev=0, Spark returns NaN from 0/0, Comet returns null from the
null_on_divide_by_zero guard). Is that case also resolved, or should
Incompatible remain for that scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
