viirya commented on code in PR #21448:
URL: https://github.com/apache/datafusion/pull/21448#discussion_r3068896276
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -2906,4 +3340,224 @@ pub(crate) mod tests {
fn columns(schema: &Schema) -> Vec<String> {
schema.fields().iter().map(|f| f.name().clone()).collect()
}
+
+ // ========================================================================
+ // Memory-limited execution tests
+ // ========================================================================
Review Comment:
Good idea! I'll add sqllogictest cases that use generate_series() with a
tight memory limit and verify spill metrics in EXPLAIN ANALYZE output.
This gives us true end-to-end coverage beyond the unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
