asolimando commented on code in PR #21081:
URL: https://github.com/apache/datafusion/pull/21081#discussion_r3066567334
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -781,6 +782,7 @@ fn collect_new_statistics(
schema: &SchemaRef,
input_column_stats: &[ColumnStatistics],
analysis_boundaries: Vec<ExprBoundaries>,
+ filtered_num_rows: Option<usize>,
Review Comment:
Good point, addressed in 404aa131d. Since we call
`distinct_count.to_inexact()`, and that `Inexact` mixed with anything else
gives `Inexact`, there is no semantics change regardless of the precision of
`filtered_num_rows`: this is fine, since after filtering the NDV is always an
estimate, but the API looks cleaner as you suggest, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
