rluvaton commented on PR #21499: URL: https://github.com/apache/datafusion/pull/21499#issuecomment-4217348007
> Thanks @rluvaton -- I left some ideas > > > once merge I will iterate over this, but this works from what I tested > > How did you test? locally > My biggest concern for all these CI jobs / improvements is the bandwidth to maintain them . We have such limited maintainer bandwidth in general. Usually ci workflows do not really change > Have you considered running this check on one of your own machines (rather than as a github action), polling for PRs to test? We have had good luck with that model and the `run benchmark` commands. I don't have one > I think external runners are better because: > > 1. They are easier to debug > 2. They are maintained outside of the normal DataFusion code repo > 3. They aren't limited to the github workflow syntax / logic (which I find very hard to debug) > > What do you think? Unfortunately I don't have my own machines and maintaining a script rather than using a github action sounds harder to maintain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
