alamb commented on code in PR #21457: URL: https://github.com/apache/datafusion/pull/21457#discussion_r3059291944
########## datafusion/datasource/src/sort_pushdown.rs: ########## @@ -0,0 +1,577 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: Since this is entirely used by file_scan_config it might make sense to reflect that in the module structure and make it a submodule of `file_scan_config` -- aka rename it to `datafusion/datasource/src/file_scan_config/sort_pushdown.rs` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
