Dandandan commented on code in PR #21480:
URL: https://github.com/apache/datafusion/pull/21480#discussion_r3055933546
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -772,12 +772,22 @@ impl MetadataLoadedParquetOpen {
prepared.physical_file_schema = Arc::clone(&physical_file_schema);
// Build predicates for this specific file
- let (pruning_predicate, page_pruning_predicate) =
build_pruning_predicates(
+ let pruning_predicate = build_pruning_predicates(
Review Comment:
Maybe better is to delay it so they are only created **after** we loaded the
page index, this avoids doing it as well for files without page index (and
avoids it in short-circuit scenarios / query cancellation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
