yoavcloud commented on code in PR #2252:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2252#discussion_r3055680957
##########
src/parser/mod.rs:
##########
@@ -1716,6 +1715,17 @@ impl<'a> Parser<'a> {
// name, resulting in `NOT 'a'` being recognized as a
`TypedString` instead of
// an unary negation `NOT ('a' LIKE 'b')`. To solve this, we
don't accept the
// `type 'string'` syntax for the custom data types at all.
+ DataType::Custom(type_name, modifiers)
+ if dialect_of!(self is PostgreSqlDialect | GenericDialect)
Review Comment:
Can we use a dialect method for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
