mbutrovich commented on code in PR #21484:
URL: https://github.com/apache/datafusion/pull/21484#discussion_r3054112905
##########
datafusion/core/tests/memory_limit/mod.rs:
##########
@@ -213,6 +213,7 @@ async fn sort_merge_join_spill() {
.with_config(config)
.with_disk_manager_builder(DiskManagerBuilder::default())
.with_scenario(Scenario::AccessLogStreaming)
Review Comment:
`is_join_arrays_equal` didn't support `Dictionary` keys — it hit the
`not_impl_err!` fallthrough. This test was passing because that error counted
as the expected "failure." `JoinKeyComparator` uses `make_comparator` which
handles all Arrow types, so the query now correctly spills and succeeds.
If you add this on main:
```
.with_expected_errors(vec!["Unsupported data type in sort merge join
comparator"])
```
the test passes, confirming it was failing for the wrong reason on main all
along.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
