timsaucer commented on code in PR #1481:
URL:
https://github.com/apache/datafusion-python/pull/1481#discussion_r3054073039
##########
crates/core/src/dataframe.rs:
##########
@@ -554,13 +554,6 @@ impl PyDataFrame {
Ok(PyTable::from(table_provider))
}
- #[pyo3(signature = (*args))]
- fn select_columns(&self, args: Vec<PyBackedStr>) ->
PyDataFusionResult<Self> {
- let args = args.iter().map(|s| s.as_ref()).collect::<Vec<&str>>();
- let df = self.df.as_ref().clone().select_columns(&args)?;
- Ok(Self::new(df))
- }
-
Review Comment:
Because we can take both arguments in select vs select_columns, we
deprecated select_columns a long time ago because it's more pythonic to have
just one interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
