neilconway commented on PR #21464:
URL: https://github.com/apache/datafusion/pull/21464#issuecomment-4206281044
Btw I tried refactoring this to use an explicit `for` (so we can dispense
with the `zero` dummy assignment), but it was a bit slower than the `map`
approach:
```
- find_in_set/string_len_8: 588.6 µs → 530.9 µs (-9.8%)
- find_in_set/string_len_32: 735.2 µs → 669.5 µs (-8.9%)
- find_in_set/string_len_1024: 7.5 ms → 7.4 ms (-1.3%)
- find_in_set/string_view_len_8: 615.7 µs → 581.0 µs (-5.6%)
- find_in_set/string_view_len_32: 743.8 µs → 708.9 µs (-4.7%)
- find_in_set/string_view_len_1024: 7.6 ms → 7.6 ms (-0.0%)
- find_in_set_scalar/string_len_8: 76.7 µs → 56.9 µs (-25.8%)
- find_in_set_scalar/string_len_32: 76.7 µs → 56.8 µs (-25.9%)
- find_in_set_scalar/string_len_1024: 76.4 µs → 56.9 µs (-25.5%)
- find_in_set_scalar/string_view_len_8: 81.5 µs → 59.0 µs (-27.6%)
- find_in_set_scalar/string_view_len_32: 85.3 µs → 59.4 µs (-30.4%)
- find_in_set_scalar/string_view_len_1024: 85.0 µs → 59.2 µs (-30.4%)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
