yoavcloud commented on code in PR #2248:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2248#discussion_r3051060557
##########
src/parser/mod.rs:
##########
@@ -10487,11 +10560,242 @@ impl<'a> Parser<'a> {
Keyword::USER => self.parse_alter_user().map(Into::into),
// unreachable because expect_one_of_keywords used above
unexpected_keyword => Err(ParserError::ParserError(
- format!("Internal parser error: expected any of {{VIEW, TYPE,
TABLE, INDEX, ROLE, POLICY, CONNECTOR, ICEBERG, SCHEMA, USER, OPERATOR}}, got
{unexpected_keyword:?}"),
+ format!("Internal parser error: expected any of {{VIEW, TYPE,
TABLE, INDEX, FUNCTION, AGGREGATE, ROLE, POLICY, CONNECTOR, ICEBERG, SCHEMA,
USER, OPERATOR}}, got {unexpected_keyword:?}"),
)),
}
}
+ fn parse_unreserved_keyword(&mut self, expected: &str) -> bool {
Review Comment:
What is the purpose of this approach to parsing keywords? Why not define the
missing words as keywords?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
