adriangb commented on PR #21322: URL: https://github.com/apache/datafusion/pull/21322#issuecomment-4187122914
> I like this, i just noticed we might need a bit more tests on `ScalarUDFImpl` in the future, but there are slts on that so could be just fine as is. Generally we prefer SLT tests. They avoid more code to compile, are easier to grok and are closer to real world usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
