Copilot commented on code in PR #1470:
URL:
https://github.com/apache/datafusion-python/pull/1470#discussion_r3034209158
##########
python/datafusion/functions.py:
##########
@@ -2596,22 +2602,111 @@ def arrow_typeof(arg: Expr) -> Expr:
return Expr(f.arrow_typeof(arg.expr))
-def arrow_cast(expr: Expr, data_type: Expr) -> Expr:
+def arrow_cast(expr: Expr, data_type: Expr | str) -> Expr:
"""Casts an expression to a specified data type.
Examples:
>>> ctx = dfn.SessionContext()
Review Comment:
This PR declares `Closes #1453`, but the issue also lists `arrow_try_cast`
as a missing scalar function. I verified there is no `arrow_try_cast` wrapper
anywhere in the repo (no Python wrapper in `python/datafusion/functions.py` and
no Rust binding in `crates/core/src/functions.rs`). Either add `arrow_try_cast`
(and a corresponding unit test) or adjust the PR description/linked issue
closure so we’re not closing the issue prematurely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
