comphead opened a new pull request, #3891: URL: https://github.com/apache/datafusion-comet/pull/3891
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes https://github.com/apache/datafusion-comet/issues/1630. ## Rationale for this change ## Summary Adds comprehensive SQL file tests for `first` and `last` aggregation functions with `IGNORE NULLS` semantics. ## Motivation The existing `first_last.sql` test file had only 3 basic queries covering `first`/`last` without any `IGNORE NULLS` coverage. The Scala test suite (`CometAggregateSuite`) has some `IGNORE NULLS` tests but several are disabled (TODO #1646). SQL file tests are the preferred approach for expression testing in Comet and provide better coverage across the `ConfigMatrix` (dictionary encoding on/off). ## What's added Tests are organized into three sections: **FIRST**, **LAST**, and **FIRST + LAST combined**, each covering: - **Basic behavior** — default (respect nulls) and `IGNORE NULLS` - **All-null groups** — verifies `NULL` is returned when no non-null values exist - **Empty table** — zero-row input - **Single row** — one non-null value, and one null value - **Multiple data types** — int, bigint, double, string, boolean (`expect_fallback` due to `SortAggregate`) - **Null positions** — nulls at the beginning, middle, and end of groups - **Boolean parameter form** — `first(val, true)` / `first(val, false)` equivalence with `IGNORE NULLS` syntax - **Expressions producing nulls** — `IF(val % 2 = 0, NULL, val)` inside aggregation - **Mixed aggregations** — `first`/`last` IGNORE NULLS alongside regular `first`/`last`, `count`, `sum` - **HAVING clause** — filtering groups based on `IGNORE NULLS` result - **Decimal type** — `DECIMAL(10,2)` - **Date type** — `DATE` values - **Large group (1000 rows)** — exercises multi-batch aggregation with sparse non-null values (every 10th row) <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## How are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
