mbutrovich commented on code in PR #3781:
URL: https://github.com/apache/datafusion-comet/pull/3781#discussion_r3029759199
##########
dev/diffs/3.4.3.diff:
##########
@@ -2350,16 +2350,17 @@ index 351c6d698fc..583d9225cca 100644
import org.apache.spark.sql.execution.FileSourceScanExec
import org.apache.spark.sql.execution.datasources.FileFormat
import org.apache.spark.sql.execution.datasources.v2.BatchScanExec
-@@ -172,6 +174,8 @@ class ParquetRowIndexSuite extends QueryTest with
SharedSparkSession {
+@@ -172,6 +174,9 @@ class ParquetRowIndexSuite extends QueryTest with
SharedSparkSession {
private def testRowIndexGeneration(label: String, conf: RowIndexTestConf):
Unit = {
test (s"$label - ${conf.desc}") {
++ // See https://github.com/apache/datafusion-comet/issues/3432
+ // native_datafusion Parquet scan does not support row index generation.
-+ assume(CometConf.COMET_NATIVE_SCAN_IMPL.get() !=
CometConf.SCAN_NATIVE_DATAFUSION)
++ assume(!Seq(CometConf.SCAN_NATIVE_DATAFUSION,
CometConf.SCAN_AUTO).contains(CometConf.COMET_NATIVE_SCAN_IMPL.get()))
Review Comment:
Why do we skip the tests if we fall back already? Couldn't we exercise the
fallback logic?
##########
dev/diffs/3.4.3.diff:
##########
@@ -2372,12 +2373,13 @@ index 351c6d698fc..583d9225cca 100644
case _ =>
}
assert(numPartitions > 0)
-@@ -291,6 +301,8 @@ class ParquetRowIndexSuite extends QueryTest with
SharedSparkSession {
+@@ -291,6 +302,9 @@ class ParquetRowIndexSuite extends QueryTest with
SharedSparkSession {
val conf = RowIndexTestConf(useDataSourceV2 = useDataSourceV2)
test(s"invalid row index column type - ${conf.desc}") {
++ // See https://github.com/apache/datafusion-comet/issues/3432
+ // native_datafusion Parquet scan does not support row index generation.
-+ assume(CometConf.COMET_NATIVE_SCAN_IMPL.get() !=
CometConf.SCAN_NATIVE_DATAFUSION)
++ assume(!Seq(CometConf.SCAN_NATIVE_DATAFUSION,
CometConf.SCAN_AUTO).contains(CometConf.COMET_NATIVE_SCAN_IMPL.get()))
Review Comment:
Same question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
