manuzhang commented on code in PR #3753:
URL: https://github.com/apache/datafusion-comet/pull/3753#discussion_r3027533477
##########
native/core/src/execution/jni_api.rs:
##########
@@ -778,33 +778,31 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_writeSortedFileNative
compression_level: jint,
tracing_enabled: jboolean,
) -> jlongArray {
- try_unwrap_or_throw(&e, |mut env| unsafe {
+ try_unwrap_or_throw(&e, |env| unsafe {
with_trace(
"writeSortedFileNative",
tracing_enabled != JNI_FALSE,
|| {
- let data_types = convert_datatype_arrays(&mut env,
serialized_datatypes)?;
+ let data_types = convert_datatype_arrays(env,
serialized_datatypes)?;
- let row_num = env.get_array_length(&row_addresses)? as usize;
- let row_addresses =
- env.get_array_elements(&row_addresses,
ReleaseMode::NoCopyBack)?;
+ let row_num = row_addresses.len(env)?;
+ let row_addresses = row_addresses.get_elements(env,
ReleaseMode::NoCopyBack)?;
- let row_sizes = env.get_array_elements(&row_sizes,
ReleaseMode::NoCopyBack)?;
+ let row_sizes = row_sizes.get_elements(env,
ReleaseMode::NoCopyBack)?;
let row_addresses_ptr = row_addresses.as_ptr();
let row_sizes_ptr = row_sizes.as_ptr();
- let output_path: String =
env.get_string(&file_path).unwrap().into();
+ let output_path: String =
file_path.try_to_string(env).unwrap();
- let checksum_enabled = checksum_enabled == 1;
Review Comment:
[`jbool` is an alias for `bool` instead of
`u8`](https://github.com/jni-rs/jni-sys/pull/23) after `jni-sys` 0.4. Do you
want me to update other `jbool` usages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
