asolimando commented on PR #20926: URL: https://github.com/apache/datafusion/pull/20926#issuecomment-4168534107
@2010YOUY01, apologies for the direct ping, would you be interesting in taking a look? Re. the discussion in https://github.com/apache/datafusion/issues/21120#issuecomment-4131266771, we have taken Trino and Spark as reference, for grouping sets we went a bit further than those systems, but I believe enough details are provided for the proposed formula (see https://github.com/apache/datafusion/pull/20926#discussion_r2942442151 for the discussion, which @buraksenn captured in code comments). Is this matching your suggestion for CBO improvements you shared in https://github.com/apache/datafusion/issues/21120#issuecomment-4131266771? This is an interesting example as it covers as "porting" of existing statistics propagation code from battle-tested systems, and a reasonable extension, so I am particularly interested in your feedback to calibrate future PRs and reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
