xitep opened a new pull request, #2291:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2291
* this suggests `Parens<T>`. hopefully advancing #1548 a bit and being the
foundation for #2050
* it is (a bit) wasteful to store the parens' location as a `Span` (since a
paren is just a single character, the start location would fully suffice), but
I simply went for consistency.
* with this PR (so far), it's used only by `Value` so that i can properly
determined the end of an `insert` statement and distinguish between "`...
VALUES ('foo' /\*xyz\*/)` and `... VALUES('foo') /\*xyz\*/`
* of course, many more places in the AST could be covered, e.g. function
params/args, subqueries, etc. if this PR is OK as is, i can put in some more
time and expand on the coverage. (just let me know.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
