goldmedal commented on PR #11361: URL: https://github.com/apache/datafusion/pull/11361#issuecomment-2221821217
> I think we can have several functions frontend but one single function in functions crate, with ExprPlanner, we can arrange the args for the single MapFunc. Also, the biggest reason why `make_map` is slow is because the way we rearrange args involved tons of clone, it is relatively easier if we rearrange args in ExprPlanner because it is the place we collect args. > > What the MapFunc's args look like depend on what is more efficient more Arrow Array. `SELECT MAP(['key1', 'key2', 'key3'], [10, 20, 30]);` seems to be the most efficient one because we don't need any other args arrangement Thanks It's a good reason for me. I can try it in the next PR (to support SQL syntax) and do some benchmarks for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
